[Master]-Bug 648538: Add mileage setup to Expense Agent wizard - #11027
[Master]-Bug 648538: Add mileage setup to Expense Agent wizard#11027v-rohangarg20 wants to merge 1 commit into
Conversation
Add a mileage-rate configuration link below the default mileage unit and warn when closing mileage setup without configured rates.
github-actions
Bot
added
AL: Apps (W1)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| trigger OnQueryClosePage(CloseAction: Action): Boolean |
There was a problem hiding this comment.
The new OnQueryClosePage trigger on page 7128 "Mileage Rate Setup" prompts "No mileage rates have been configured. The standard mileage rate will be used. Do you want to continue?" every time the page is closed with an empty table. This page has UsageCategory = Lists, so it is reachable directly from the Lists menu/search, not only from the Expense Agent Setup Wizard drill-down added in this PR. A user who opens the list independently (e.g., just to check whether rates exist) and closes it without adding a rate will see a setup-wizard-flavored confirmation that is confusing outside the wizard flow, and answering No leaves the page open with no clear indication of what action is expected. Consider moving this confirmation into the wizard's own close/validation flow, or scoping it so it only prompts when the page was opened modally from the wizard.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.36.6
Good Sense Reviewer - Round 1Recommendation: AcceptWhat this PR doesThis PR adds a link from the Expense Agent setup wizard to the existing Mileage Rate Setup page, and warns when that page is closed while no mileage rates exist. The change is targeted: the new wizard link follows the existing link-field pattern, the setup page already exposes vehicle type and date ranges, and the warning does not change mileage-rate selection or fallback calculation. Problem-solution fitFit: Strong The reported scenario is that date- and vehicle-based mileage setup is not discoverable from the wizard. The new link opens the existing setup page that contains those fields, and the empty-page warning matches the intended fallback to the standard mileage rate. SuggestionsNone. Risk assessment and necessityRisk: Low. The change is UI navigation plus a close confirmation, and it does not alter mileage amount calculation, posting, table validation, public events, or BaseApp event dependencies. The warning can appear for any user who closes an empty Mileage Rate Setup page, but it is informational and defaults to continue. Necessity: The change is needed to make existing vehicle- and date-based mileage rates reachable from the setup wizard. The scope is narrow and uses existing setup infrastructure.
|
2 participants
Fixes AB#648538
Adds mileage configuration to the Expense Agent setup wizard and warns users when they close Mileage Rate Setup without configuring any mileage rates.
Changes are limited to:
AL build completed successfully.